[Distributed/Snapshot/Restore] Add configurations: use_path_style && use_chunked_encoding #43738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wujinhu
changed the title
Contributor
Author
|
Duplicate with 41966. I will open another PR to add use_chunked_encoding configuration after it is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two configurations: use_path_style and use_chunked_encoding.
Reasons:
use_path_style: Amazon S3 path will be deprecated. Here is its plan https://aws.amazon.com/cn/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/.
And some S3-compatible services do not support path style to access a bucket.
use_chunked_encoding: Some S3-compatible services do not support chunked encoding.
So, we should add these two configurations and users can use repository-s3 to access S3-compatible services.