Remove the 6.7 version constants. #42039
Conversation
jtibshirani
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
jtibshirani
force-pushed
the
remove-version-constant
branch
4 times, most recently
from
e83b021 to
ba3f5ba
Compare
jtibshirani
force-pushed
the
remove-version-constant
branch
from
ba3f5ba to
83da48c
Compare
talevy
left a comment
talevy
left a comment
There was a problem hiding this comment.
LGTM, just left two comments around random version testing
| public void testSnapshotInProgressException() throws IOException { | ||
| SnapshotInProgressException orig = new SnapshotInProgressException("boom"); | ||
| Version version = VersionUtils.randomVersionBetween(random(), Version.V_6_7_0, Version.CURRENT); | ||
| Version version = VersionUtils.randomVersionBetween(random(), Version.V_7_0_0, Version.CURRENT); |
There was a problem hiding this comment.
no need to do here, but we could probably replace this so that we do not need to worry about it in the big 7.x refactor.
to something like
Version version = Versionutils.randomVersion()
There was a problem hiding this comment.
I think it should be VersionUtils.randomIndexCompatibleVersion(random())
There was a problem hiding this comment.
👍 I'll make this change in the current PR.
| // developments | ||
| if (randomBoolean()) { | ||
| oldNode = addAnotherDataNodeWithVersion(this.clusterService, randomFrom(Version.V_6_7_0, Version.V_7_0_0)); | ||
| oldNode = addAnotherDataNodeWithVersion(this.clusterService, Version.V_7_0_0); |
There was a problem hiding this comment.
should this be a range like so?
oldNode = addAnotherDataNodeWithVersion(this.clusterService, VersionUtils.randomVersionBetween(random(), Version.V_7_0_0, Version.V_7_1_0));
There was a problem hiding this comment.
Makes sense given the comment above, will update this too.
|
@elasticmachine run elasticsearch-ci/packaging-sample |
|
@elasticmachine run elasticsearch-ci/1 |
This PR removes all constants of the form `Version.V_6_7_*`, since master no longer needs to account for them. Relates to elastic#41164.
5 participants
This PR removes all constants of the form
Version.V_6_7_*, since master nolonger needs to account for them.
Relates to #41164.