[ML] checking if p-tasks metadata is null before updating state (#41091) #41124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tic#41091) * [ML] checking if p-tasks metadata is null before updating state * Adding test that validates fix * removing debug println
Collaborator
|
Pinging @elastic/ml-core |
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…tic#41091) (elastic#41124) * [ML] checking if p-tasks metadata is null before updating state * Adding test that validates fix * removing debug println
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If PersistentTasksCustomMetaData.TYPE is null, we would put a null value in the cluster state, which will fail the submitStateUpdateTask.
This does a null check to verify it is non-null before adding it to the metadata. All of the other methods in the class that interact with a PersistentTasksCustomMetaData already do a null check
closes #41090
forward port of: #41091