[ML] Data Frame minor tidy ups #40548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidkyle
commented
Mar 27, 2019
davidkyle
commented
- Remove unused RequestBuilders
- Remove the toXContent methods of request objects where not necessary
- Don't suppress -XLint warnings. For Remove disable Xlint warning from gradle files. #40366
- Add a missing test for StartDataFrameTransformTaskAction.Request
Collaborator
|
Pinging @elastic/ml-core |
benwtrent
approved these changes
Mar 27, 2019
23 tasks
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Mar 28, 2019
Remove Xlint-rawtypes option and remove unused request builders. Not all requests need to implement ToXContent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.