Make remote cluster resolution stricter #40419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
added
>breaking
:Distributed Indexing/Distributed
Collaborator
|
Pinging @elastic/es-distributed |
Remote cluster resolution is currently lenient, to support local indices that may contain `:` in their name. From 8.0 on, there can no longer be indices in the cluster that contain `:` in their name, hence we can make remote cluster resolution stricter. Instead of treating any index expression containing a `:` whenever there is no corresponding matching remote cluster registered, we now throw a `NoSuchRemoteClusterException`. Closes elastic#37863
javanna
force-pushed
the
enhancement/remote_cluster_resolver_strict
branch
from
565cf10 to
8d1404f
Compare
Member
Author
|
run elasticsearch-ci/packaging-sample |
Collaborator
|
Pinging @elastic/es-core-infra |
ywelsch
removed
the
:Distributed Indexing/Distributed
Member
Author
|
This effectively affects only CCS, as CCR already throws NoSuchRemoteClusterException when a non existing remote cluster is referenced. |
javanna
added
:Search/Search
Collaborator
|
Pinging @elastic/es-search |
Member
Author
|
Thanks @jimczi !!! |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 4, 2019
* elastic/master: (25 commits) Rollup ignores time_zone on date histogram (elastic#40844) HLRC: fix uri encode bug when url path starts with '/' (elastic#34436) Mutes GatewayIndexStateIT.testRecoverBrokenIndexMetadata Docs: Pin two IDs in the rest client (elastic#40785) Adds version 6.7.2 [DOCS] Remind users to include @ symbol when applying license file (elastic#40688) HLRC: Convert xpack methods to client side objects (elastic#40705) Allow ILM to stop if indices have nonexistent policies (elastic#40820) Add an OpenID Connect authentication realm (elastic#40674) [DOCS] Rewrite query def (elastic#40746) [ML] Changes default destination index field mapping and adds scripted_metric agg (elastic#40750) Docs: Drop inline callouts from painless book (elastic#40805) [ML] refactoring start task a bit, removing unused code (elastic#40798) [DOCS] Document index.load_fixed_bitset_filters_eagerly (elastic#40780) Make remote cluster resolution stricter (elastic#40419) [ML] Add created_by info to usage stats (elastic#40518) SQL: [Docs] Small fixes for CURRENT_TIMESTAMP docs (elastic#40792) convert modules to use testclusters (elastic#40804) Replace javax activation with jakarta activation (elastic#40247) Document restrictions on fuzzy matching when using synonyms (elastic#40783) ...
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Remote cluster resolution is currently lenient, to support local indices that may contain `:` in their name. From 8.0 on, there can no longer be indices in the cluster that contain `:` in their name, hence we can make remote cluster resolution stricter. Instead of treating any index expression containing a `:` whenever there is no corresponding matching remote cluster registered, we now throw a `NoSuchRemoteClusterException`. Closes elastic#37863
Contributor
|
Related to #23892 |
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote cluster resolution is currently lenient, to support local
indices that may contain
:in their name. From 8.0 on, there can nolonger be indices in the cluster that contain
:in their name, hencewe can make remote cluster resolution stricter. Instead of treating
as local any index expression containing a
:whenever there is no correspondingmatching remote cluster registered, we now throw a
NoSuchRemoteClusterException.Closes #37863