Remove Obsolete BWC Serialization Logic #39879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
original-brownbear
commented
Mar 9, 2019
original-brownbear
commented
- We only support 7.0+ now in 8.0 => all BwC serialization logic pertaining to 6.x and older is dead code
* We only support 7.0+ now in 8.0 => all BwC serialization logic pertaining to 6.x and older is dead code
original-brownbear
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
Jenkins run elasticsearch-ci/1 (checkstyle ran into a SO exception) |
jasontedor
approved these changes
Mar 9, 2019
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
LGTM. Thanks for doing this.
Contributor
Author
|
@jasontedor np + thanks for reviewing :) |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Mar 10, 2019
* Same as elastic#39879, all Bwc logic related to pre-7.0 versions is obsolete in master (8.0) now
original-brownbear
added a commit
that referenced
this pull request
Mar 13, 2019
* Remove Obsolete BwC Serialization Logic * Same as #39879, all Bwc logic related to pre-7.0 versions is obsolete in master (8.0) now
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Mar 14, 2019
* Same as elastic#39879 and elastic#39883 <- no need for BwC logic that covers pre-7.0 versions in 8.0
original-brownbear
added a commit
that referenced
this pull request
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.