Skip to content

[Data-Frame] make the config be strictly parsed on _preview #39713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 9, 2019
Merged

[Data-Frame] make the config be strictly parsed on _preview #39713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
709eb7d
[Data-Frame] make the config be strictly parsed on _preview
benwtrent Mar 5, 2019
20e4789
adding test to verify strictly parsing
benwtrent Mar 7, 2019
68b9221
Merge branch 'master' into feature/data-frame-make-preview-strictly-p…
benwtrent Mar 8, 2019
eb73449
adjusting test after master merge
benwtrent Mar 8, 2019
3ba28b3
Merge branch 'master' into feature/data-frame-make-preview-strictly-p…
benwtrent Mar 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...n/java/org/elasticsearch/xpack/core/dataframe/action/PreviewDataFrameTransformAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public static Request fromXContent(final XContentParser parser) throws IOExcepti
.createParser(parser.getXContentRegistry(),
LoggingDeprecationHandler.INSTANCE,
BytesReference.bytes(xContentBuilder).streamInput())) {
return new Request(DataFrameTransformConfig.fromXContent(newParser, "transform-preview", true));
return new Request(DataFrameTransformConfig.fromXContent(newParser, "transform-preview", false));
}
}

Expand Down
14 changes: 14 additions & 0 deletions x-pack/plugin/src/test/resources/rest-api-spec/test/data_frame/preview_transforms.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,17 @@ setup:
- match: { preview.2.airline: foo }
- match: { preview.2.by-hour: "2017-02-49 01" }
- match: { preview.2.avg_response: 42.0 }

---
"Test preview transform with invalid config":
- do:
catch: /\[data_frame_terms_group\] unknown field \[not_a_terms_param\]/
data_frame.preview_data_frame_transform:
body: >
{
"source": "airline-data",
"pivot": {
"group_by": {"airline": {"terms": {"not_a_terms_param": "airline"}}},
"aggs": {"avg_response": {"avg": {"field": "responsetime"}}}
}
}