From 33c26b992902b32cb2b4de784b6f1e776a1828fc Mon Sep 17 00:00:00 2001 From: Lee Hinman Date: Thu, 14 Feb 2019 10:40:04 -0700 Subject: [PATCH] Check that delete index request succeeded in test teardown (#38903) When tearing down from `ESSingleNodeTestCase` we perform a delete on "*" indices, it some cases, however, those indices are not fully deleted. Rather than have a failure occur later down the change (see: https://github.com/elastic/elasticsearch/issues/30290#issuecomment-463589008 ) the failure should occurr immediately so it can be diagnosed more easily. --- .../java/org/elasticsearch/test/ESSingleNodeTestCase.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/framework/src/main/java/org/elasticsearch/test/ESSingleNodeTestCase.java b/test/framework/src/main/java/org/elasticsearch/test/ESSingleNodeTestCase.java index 4443416208321..343614081c48c 100644 --- a/test/framework/src/main/java/org/elasticsearch/test/ESSingleNodeTestCase.java +++ b/test/framework/src/main/java/org/elasticsearch/test/ESSingleNodeTestCase.java @@ -30,6 +30,7 @@ import org.elasticsearch.cluster.metadata.MetaData; import org.elasticsearch.cluster.routing.allocation.DiskThresholdSettings; import org.elasticsearch.common.Priority; +import org.elasticsearch.common.Strings; import org.elasticsearch.common.settings.Settings; import org.elasticsearch.common.unit.TimeValue; import org.elasticsearch.common.util.BigArrays; @@ -127,6 +128,9 @@ public void tearDown() throws Exception { metaData.persistentSettings().size(), equalTo(0)); assertThat("test leaves transient cluster metadata behind: " + metaData.transientSettings().keySet(), metaData.transientSettings().size(), equalTo(0)); + GetIndexResponse indices = client().admin().indices().prepareGetIndex().addIndices("*").get(); + assertThat("test leaves indices that were not deleted: " + Strings.arrayToCommaDelimitedString(indices.indices()), + indices.indices(), equalTo(Strings.EMPTY_ARRAY)); if (resetNodeAfterTest()) { assert NODE != null; stopNode();