Skip to content

Conversation

@danielmitterdorfer
Copy link
Member

No description provided.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

* Create snapshot role {pull}35820[#35820] (issue: {issue}34454[#34454])

CCR::
* Integrate retention leases to recovery from remote [OPEN] {pull}38829[#38829] (issue: {issue}37165[#37165])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix the labels on this one as the PR is showing as still open. We should label it as 6.7.1 for now and then the relabel process will move it back to 7.0.0 when a build candidate contains this change after its merged

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I missed that this one is still open. Thanks for spotting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, we expect that this particular PR will be included in 6.7.0 and thus I will not relabel but only remove it from the release notes for now.


Infra/Core::
* Use DateFormatter in monitoring instead of joda code {pull}38309[#38309]
* Use dateformatter in ingest-common to log deprecations {pull}38099[#38099]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure these should be labelled with upgrade since they are not changing the version of a dependency. >enhancement or >bug seems more appropriate for these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I've relabelled the PRs accordingly.

@danielmitterdorfer
Copy link
Member Author

@colings86 I've addressed your review comments now. Could you please have another look?

Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @danielmitterdorfer

@danielmitterdorfer danielmitterdorfer merged commit d716cd7 into elastic:6.7 Feb 13, 2019
@danielmitterdorfer danielmitterdorfer deleted the 6-7-0-release-notes branch February 13, 2019 12:54
@lcawl
Copy link
Contributor

lcawl commented Feb 19, 2019

Sorry I didn't see this sooner. I've created #39155 to make this new release notes page show up in the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes v6.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants