-
Notifications
You must be signed in to change notification settings - Fork 25.6k
ML allow aliased .ml-anomalies* index on PUT Job #38821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benwtrent
merged 1 commit into
elastic:master
from
benwtrent:bug/ml-allow-aliased-results-index-on-put-job
Feb 13, 2019
Merged
ML allow aliased .ml-anomalies* index on PUT Job #38821
benwtrent
merged 1 commit into
elastic:master
from
benwtrent:bug/ml-allow-aliased-results-index-on-put-job
Feb 13, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core |
droberts195
approved these changes
Feb 13, 2019
droberts195
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for fixing this @benwtrent. I looked through all the other usages of Job.getInitialResultsIndexName and I cannot see another place where it would matter whether the name it returns is an index or an alias.
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Feb 13, 2019
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Feb 13, 2019
This was referenced Feb 13, 2019
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 13, 2019
* master: Improve CcrRepositoryIT mappings tests (elastic#38817) Unmute testClusterJoinDespiteOfPublishingIssues and testElectMasterWithLatestVersion (elastic#38555) ML allow aliased .ml-anomalies* index on PUT Job (elastic#38821) Filter out upgraded version index settings when starting index following (elastic#38838) Handle the fact that `ShardStats` instance may have no commit or seqno stats (elastic#38782) Edits to text of Profile API documentation (elastic#38742) muted test
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 13, 2019
* master: Improve CcrRepositoryIT mappings tests (elastic#38817) Unmute testClusterJoinDespiteOfPublishingIssues and testElectMasterWithLatestVersion (elastic#38555) ML allow aliased .ml-anomalies* index on PUT Job (elastic#38821) Filter out upgraded version index settings when starting index following (elastic#38838) Handle the fact that `ShardStats` instance may have no commit or seqno stats (elastic#38782) Edits to text of Profile API documentation (elastic#38742) muted test
benwtrent
added a commit
that referenced
this pull request
Feb 13, 2019
benwtrent
added a commit
that referenced
this pull request
Feb 13, 2019
benwtrent
added a commit
that referenced
this pull request
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually tested in the following manner:
.ml-anomalies-sharedindex.ml-anomalies-sharedinto new index.ml-anomalies-shared.ml-anomalies-sharedto point to new concrete index.After the test
closes #38773