From 47535bdff4f1dfd877cfeb8a9e14a69da82c4edd Mon Sep 17 00:00:00 2001 From: Nhat Nguyen Date: Wed, 30 Jan 2019 19:00:15 -0500 Subject: [PATCH] Correct arg names when update mapping/settings from leader These two arguments are not named incorrectly and caused confusion. --- .../xpack/ccr/action/ShardFollowNodeTask.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/x-pack/plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/action/ShardFollowNodeTask.java b/x-pack/plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/action/ShardFollowNodeTask.java index 233085c0a6857..a4f02707bc40f 100644 --- a/x-pack/plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/action/ShardFollowNodeTask.java +++ b/x-pack/plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/action/ShardFollowNodeTask.java @@ -133,21 +133,21 @@ void start( } // updates follower mapping, this gets us the leader mapping version and makes sure that leader and follower mapping are identical - updateMapping(0L, followerMappingVersion -> { + updateMapping(0L, leaderMappingVersion -> { synchronized (ShardFollowNodeTask.this) { - currentMappingVersion = followerMappingVersion; + currentMappingVersion = leaderMappingVersion; } - updateSettings(followerSettingsVersion -> { + updateSettings(leaderSettingsVersion -> { synchronized (ShardFollowNodeTask.this) { - currentSettingsVersion = followerSettingsVersion; + currentSettingsVersion = leaderSettingsVersion; } LOGGER.info( "{} following leader shard {}, follower global checkpoint=[{}], mapping version=[{}], settings version=[{}]", params.getFollowShardId(), params.getLeaderShardId(), followerGlobalCheckpoint, - followerMappingVersion, - followerSettingsVersion); + leaderMappingVersion, + leaderSettingsVersion); coordinateReads(); }); });