Fix topDocs.totalHits assignment on scroll queries #37180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimczi
added
>non-issue
:Search/Search
Collaborator
|
Pinging @elastic/es-search |
jimczi
changed the title
This change fixes an unreleased bug that assigns the wrong totalHits to scroll queries. Closes elastic#3717 9
jimczi
force-pushed
the
bug/scroll_total_hits
branch
from
e4b1fe0 to
3f5c4bb
Compare
Contributor
Author
|
@elasticmachine run gradle build tests 1 |
Contributor
Author
|
Last failure is not related to this bug (jvm crash): @elasticmachine run gradle build tests 1 |
Contributor
Author
|
Unrelated failure: @elasticmachine run gradle build tests 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an unreleased bug that assigns the wrong totalHits to scroll
queries.
Closes #37179