[API] spelling: java script (not JavaScript) #37057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoref
force-pushed
the
spelling-api-javascript
branch
from
44523a4 to
f5a7354
Compare
Collaborator
|
Pinging @elastic/es-core-infra |
Member
|
@alpar thoughts about this one? |
Member
|
test this please |
Contributor
|
This is not JavaScript the programming language, but Java code executed as a script with |
jsoref
force-pushed
the
spelling-api-javascript
branch
from
f5a7354 to
1b94243
Compare
jsoref
changed the title
Contributor
Author
|
@javanna : can you retest this? |
Member
|
retest this please |
1 similar comment
Member
|
retest this please |
alpar-t
approved these changes
Jan 14, 2019
Member
|
@atorok can you take care of merging this one please? |
Contributor
|
@elasticmachine run elasticsearch-ci-1 |
Contributor
|
@elasticmachine run elasticsearch-ci/1 |
alpar-t
pushed a commit
that referenced
this pull request
Jan 31, 2019
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 31, 2019
* master: (100 commits) Push primary term to replication tracker (elastic#38044) Introduce ability to minimize round-trips in CCS (elastic#37828) Don't Assert Ack on when Publish Timeout is 0 in Test (elastic#38077) Reduce object creation in Rounding class (elastic#38061) Treat put-mapping calls with `_doc` as a top-level key as typed calls. (elastic#38032) Fix test bug when testing the merging of mappings and templates. (elastic#38021) spelling: java script -- not JavaScript (elastic#37057) Enable SSL in reindex with security QA tests (elastic#37600) Disable BWC tests during backport (elastic#38074) SQL: Added SSL configuration options tests (elastic#37875) Minor fixes in the release notes script. (elastic#37967) Fix typo in docs. (elastic#38018) Update Lucene repo for 7.0.0-alpha2 (elastic#37985) Fix size of rolling-upgrade bootstrap config (elastic#38031) fix DateIndexNameProcessorTests offset pattern (elastic#38069) Speed up converting of temporal accessor to zoned date time (elastic#37915) Work around JDK8 timezone bug in tests (elastic#37968) Correct arg names when update mapping/settings from leader (elastic#38063) Introduce ssl settings to reindex from remote (elastic#37527) Mute testRetentionLeasesSyncOnExpiration ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runJavascript/runJavaScriptappears to be an internal API which should get a distinct review. (Note: I've dropped all of the other instances ofJavaScriptas they're part of #37046)split from #37035
Note: there are two arguments here:
run+javascriptand thatjavascriptwas capitalized asJavascriptbecause of camelCasing.JavaScriptis a brand and should only be written asJavaScriptorjavascriptand never asJavascript.I'm on the fence about the correct argument.