Docs: add clarification about geohash use in geohashgrid agg #36901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds example on translating geohashes returned by geohashgrid agg as bucket keys into geo bounding box filters in elasticsearch as well as 3rd party applications. Closes elastic#36413
imotov
added
>docs
Collaborator
|
Pinging @elastic/es-analytics-geo |
polyfractal
approved these changes
Jan 3, 2019
Contributor
polyfractal
left a comment
polyfractal
left a comment
There was a problem hiding this comment.
Tiny comment which you can ignore if you like. LGTM!
I'm happy how small the JS snippet turned out to be :)
| -------------------------------------------------- | ||
| // TESTRESPONSE[s/\.\.\./"took": $body.took,"_shards": $body._shards,"hits":$body.hits,"timed_out":false,/] | ||
|
|
||
| For "zooming in" in the system that don't support geohashes, the bucket keys should be translated into bounding boxes using |
Contributor
There was a problem hiding this comment.
Nit: perhaps For "zooming in" on systems that don't [...] ? The double "in" made me stumble reading it :)
Contributor
Author
|
Because #30698 is breaking and was merged only into 7.0, the first example can be only merged into 7.x. |
imotov
added a commit
that referenced
this pull request
Jan 3, 2019
Adds an example on translating geohashes returned by geohashgrid agg as bucket keys into geo bounding box filters in elasticsearch as well as 3rd party applications. Closes #36413
imotov
added a commit
that referenced
this pull request
Jan 3, 2019
Adds an example on translating geohashes returned by geohashgrid agg as bucket keys into geo bounding box filters in elasticsearch as well as 3rd party applications. Closes #36413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds example on translating geohashes returned by geohashgrid agg
as bucket keys into geo bounding box filters in elasticsearch as well
as 3rd party applications.
Closes #36413