[Docs] Delete explanation for completion suggester default analyzer choice #36720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hoice The explanation given in the completion suggester documentation why we use the "simple" analyzer as the default is no longer valid. Since we still use "simple" as the default, we should just delete the explanation that doesn't fit anymore. Closes elastic#36715
cbuescher
added
>docs
Collaborator
|
Pinging @elastic/es-search |
cbuescher
changed the title
javanna
approved these changes
Apr 9, 2019
Member
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
LGTM, let's get it in @cbuescher ?
Member
Author
|
@javanna sure, thanks for the review |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 9, 2019
…forced-unsafe-publication * elastic/master: Improve Watcher test framework resiliency (elastic#40658) Fix order of request body search parameter names in documentation (elastic#40777) Node repurpose tool docs (elastic#40525) [Docs] Delete explanation for completion suggester default analyzer choice (elastic#36720) Revert "Revert "Change HLRC CCR response tests to use AbstractResponseTestCase base class. (elastic#40257)"" (elastic#40971) Short-circuit rebalancing when disabled (elastic#40966)
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…hoice (elastic#36720) The explanation given in the completion suggester documentation why we use the "simple" analyzer as the default is no longer valid. Since we still use "simple" as the default, we should just delete the explanation that doesn't fit anymore. Closes elastic#36715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explanation given in the completion suggester documentation why we use the
"simple" analyzer as the default is no longer valid. Since we still use "simple"
as the default, we should just delete the explanation that doesn't fit anymore.
Closes #36715