Build: Fix jdbc jar pom to not include deps #36036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds back the exclusion of dependencies from the pom file for the jdbc jar, which was accidentally lost in elastic#32014
rjernst
added
>bug
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
|
@elasticmachine test this please |
1 similar comment
Member
Author
|
@elasticmachine test this please |
nik9000
reviewed
Nov 29, 2018
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
I believe this is what I had to do before I started using the bundled configuration, yeah.
nik9000
approved these changes
Nov 29, 2018
rjernst
added a commit
that referenced
this pull request
Nov 29, 2018
This commit adds back the exclusion of dependencies from the pom file for the jdbc jar, which was accidentally lost in #32014
rjernst
added a commit
that referenced
this pull request
Nov 29, 2018
This commit adds back the exclusion of dependencies from the pom file for the jdbc jar, which was accidentally lost in #32014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds back the exclusion of dependencies from the pom file
for the jdbc jar, which was accidentally lost in #32014