ingest: documentation for the drop processor #34570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelandis
added
>docs
Collaborator
|
Pinging @elastic/es-core-infra |
11 tasks
|
|
||
| [[drop-processor]] | ||
| === Drop Processor | ||
| Drops the document without raising any an errors. This is useful to prevent the document from |
original-brownbear
approved these changes
Oct 18, 2018
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
@jakelandis thanks LGTM
rjernst
approved these changes
Oct 23, 2018
| -------------------------------------------------- | ||
| { | ||
| "drop": { | ||
| "if" : "ctx.tags.contains('production') != true" |
Member
There was a problem hiding this comment.
If you want to show an equality check, can it be with a string value? contains already returns a boolean, so there is no need to check equality.
Contributor
Author
There was a problem hiding this comment.
@rjernst good call! i updated the example for simple string example (that can't throw a NPE). Tangentially, I am working on more comprehensive documentation around the conditional.
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Oct 23, 2018
jakelandis
added a commit
that referenced
this pull request
Oct 24, 2018
Contributor
Author
|
6.5 backport: aed947f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #33188