Add minimal sanity checks to custom/scripted similarities. (backport) #33893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add minimal sanity checks to custom/scripted similarities. Lucene 8 introduced more constraints on similarities, in particular: - scores must not be negative, - scores must not decrease when term freq increases, - scores must not increase when norm (interpreted as an unsigned long) increases. We can't check every single case, but could at least run some sanity checks. Backport of elastic#33564
jpountz
added
>enhancement
:Search Relevance/Ranking
Collaborator
|
Pinging @elastic/es-search-aggs |
romseygeek
approved these changes
Sep 20, 2018
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
I let one comment, which doesn't really need to be acted on. Otherwise LGTM
| } | ||
|
|
||
| private static class SingleNormLeafReader extends LeafReader { | ||
|
|
Contributor
There was a problem hiding this comment.
I do wonder if this class should be in a separate utility file somewhere? It's a third of the entire file length. On the other hand, this is all going away in master, so maybe it doesn't matter.
Contributor
Author
There was a problem hiding this comment.
Good point. I'll leave things this way though as master doesn't have the issue so it's not a big deal like you said.
jimczi
approved these changes
Sep 20, 2018
Contributor
Author
|
Thanks @jimczi and @romseygeek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add minimal sanity checks to custom/scripted similarities.
Lucene 8 introduced more constraints on similarities, in particular:
increases.
We can't check every single case, but could at least run some sanity checks.
Backport of #33564