HLRC: ML Update Job #33392
Merged
HLRC: ML Update Job #33392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core |
Collaborator
|
Pinging @elastic/es-core-infra |
98 tasks
Contributor
dimitris-athanasiou
left a comment
dimitris-athanasiou
left a comment
There was a problem hiding this comment.
Looks good! Left a few minor comments.
| } | ||
|
|
||
| /** | ||
| * Updates a Machine Learning {@link org.elasticsearch.client.ml.job.config.Job} properties |
Contributor
There was a problem hiding this comment.
should we delete properties?
| */ | ||
| public class UpdateJobRequest extends ActionRequest implements ToXContentObject { | ||
|
|
||
| private JobUpdate update; |
| [[java-rest-high-x-pack-ml-update-job-request]] | ||
| ==== Update Job Request | ||
|
|
||
| A `UpdateJobRequest` object gets created with an `JobUpdate` object. |
Member
Author
There was a problem hiding this comment.
I should just always make The so there is a certain authority and exactness to it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to update a Machine Learning job through the HLRC.
This relates to (#29827)