Search: Support of wildcard on docvalue_fields #32980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with stored_fields, docvalue_fields should support the use of wildcards. See also: elastic#26390 Closes elastic#26299
iverase
added
>enhancement
:Search/Search
Collaborator
|
Pinging @elastic/es-search-aggs |
jimczi
reviewed
Aug 20, 2018
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
Thanks @iverase , it looks good overall.
I left a comment regarding the error message when too many docvalue_fields are requested. Can you also update the documentation to explain this new behavior in:
docs/reference/search/request/docvalue-fields.asciidoc ?
| + "] but was [" + source.docValueFields().size() + "]. This limit can be set by changing the [" | ||
| + IndexSettings.MAX_DOCVALUE_FIELDS_SEARCH_SETTING.getKey() + "] index level setting."); | ||
| "Trying to retrieve too many docvalue_fields. Must be less than or equal to: [" + maxAllowedDocvalueFields | ||
| + "] but was [" + source.docValueFields().size() + "]. This limit can be set by changing the [" |
Contributor
There was a problem hiding this comment.
Should it be docValueFields().size() since source.docValueFields().size() contains the patterns ?
Contributor
Author
There was a problem hiding this comment.
You are totally right :)
behavior of doc values fields.
jpountz
approved these changes
Aug 20, 2018
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
LGTM, I only left a comment about the docs snippet.
| "docvalue_fields" : [ | ||
| { | ||
| "field": "*field", <1> | ||
| "format": "use_field_mapping" <2> |
Contributor
There was a problem hiding this comment.
This option is deprecated in 7.x so I suspect this will make the docs tests fail. We could do just docvalue_fields: [ "*field" ].
Contributor
Author
There was a problem hiding this comment.
Shall I update the docs or this should be addressed in a different issue?
Contributor
There was a problem hiding this comment.
Sorry this is my bad, I assumed that #30831 had been merged, which is not true. There is nothing to fix in your PR.
iverase
added a commit
that referenced
this pull request
Aug 23, 2018
martijnvg
added a commit
that referenced
this pull request
Aug 24, 2018
* es/master: (62 commits) [DOCS] Add docs for Application Privileges (#32635) Add versions 5.6.12 and 6.4.1 Do NOT allow termvectors on nested fields (#32728) [Rollup] Return empty response when aggs are missing (#32796) [TEST] Add some ACL yaml tests for Rollup (#33035) Move non duplicated actions back into xpack core (#32952) Test fix - GraphExploreResponseTests should not randomise array elements Closes #33086 Use `addIfAbsent` instead of checking if an element is contained TESTS: Fix Random Fail in MockTcpTransportTests (#33061) HLRC: Fix Compile Error From Missing Throws (#33083) [DOCS] Remove reload password from docs cf. #32889 HLRC: Add ML Get Buckets API (#33056) Watcher: Improve error messages for CronEvalTool (#32800) Search: Support of wildcard on docvalue_fields (#32980) Change query field expansion (#33020) INGEST: Cleanup Redundant Put Method (#33034) SQL: skip uppercasing/lowercasing function tests for AZ locales as well (#32910) Fix the default pom file name (#33063) Switch ml basic tests to new style Requests (#32483) Switch some watcher tests to new style Requests (#33044) ...
martijnvg
added a commit
that referenced
this pull request
Aug 24, 2018
* es/6.x: (58 commits) [DOCS] Add docs for Application Privileges (#32635) Add versions 5.6.12 and 6.4.1 [Rollup] Return empty response when aggs are missing (#32796) [TEST] Add some ACL yaml tests for Rollup (#33035) Test fix - GraphExploreResponseTests should not randomise array elements Closes #33086 Use `addIfAbsent` instead of checking if an element is contained HLRC: Fix Compile Error From Missing Throws (#33083) [DOCS] Remove reload password from docs cf. #32889 Use a dedicated ConnectionManger for RemoteClusterConnection (#32988) Watcher: Improve error messages for CronEvalTool (#32800) HLRC: Add ML Get Buckets API (#33056) Change query field expansion (#33020) Search: Support of wildcard on docvalue_fields (#32980) Add beta label to MSI on install Elasticsearch page (#28126) SQL: skip uppercasing/lowercasing function tests for AZ locales as well (#32910) [DOCS] Drafts Elasticsearch 6.4.0 release notes (#33039) Fix the default pom file name (#33063) Fix backport of switch ml basic tests to new style Requests (#32483) Switch ml basic tests to new style Requests (#32483) Switch some watcher tests to new style Requests (#33044) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with stored_fields, docvalue_fields should support the use of wildcards.
See also: #26390
Closes #26299