Skip to content

Conversation

@geekpete
Copy link
Contributor

Minor tweak to fix an example yaml config.

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just saw your previous commit (a454bf2) is only on 6.2 so far, are you also going to merge both to the upstream branches?

Also, that commit doesn't have a PR, could you open one even for small changes like this in the future? It makes it easier to track versions and makes it possible to run tests on it. Even minor docs changes have the potential of breaking our build. Thanks.

@cbuescher cbuescher added >docs General docs changes :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v6.2.5 labels May 24, 2018
@cbuescher cbuescher self-assigned this May 24, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@geekpete
Copy link
Contributor Author

Can totally do a PR in future, the first commit I'd done in by accidentally hitting commit instead of PR and facepalmed immediately after I'd done it.

martijnvg added a commit that referenced this pull request May 25, 2018
* es/master:
  [TEST] Mute {p0=snapshot.get_repository/10_basic/Verify created repository} YAML test
  Verify signatures on official plugins (#30800)
  [Docs] Add reindex.remote.whitelist example (#30828)
dnhatn added a commit that referenced this pull request May 28, 2018
* 6.x:
  Fix double semicolon in import statement
  [TEST] Fix minor random bug from #30794
  Enabling testing against an external cluster (#30885)
  SQL: Remove the last remaining server dependencies from jdbc (#30771)
  Add public key header/footer (#30877)
  Include size of snapshot in snapshot metadata (#29602)
  QA: Test template creation during rolling restart (#30850)
  REST high-level client: add put ingest pipeline API (#30793)
  Do not serialize basic license exp in x-pack info (#30848)
  [docs] explainer for java packaging tests (#30825)
  Verify signatures on official plugins (#30800)
  [DOCS] Document index name limitations (#30826)
  [Docs] Add reindex.remote.whitelist example (#30828)
@jpountz jpountz added v6.3.0 and removed v6.3.1 labels Jun 13, 2018
@geekpete geekpete deleted the geekpete-patch-3 branch November 9, 2018 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >docs General docs changes v6.2.5 v6.3.0 v6.4.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants