Use a private Directory for split / shrink #30567
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucene IW checks for pending deletes before it starts. In the split / shrink case we might delete files which can cause this check to trip. Since we know that these files are not subject for reusal we can use a private directory instance for this operation to prevent unnecessary busy waiting but still keep the checks for subsequent useage. Closes elastic#30416
s1monw
added
>bug
:Distributed Indexing/Store
Collaborator
|
Pinging @elastic/es-distributed |
jpountz
approved these changes
May 14, 2018
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
It works for me, but I think I liked your idea of wrapping our directories in order to disable checkPendingDeletes better since it avoids the creation of multiple directories over the same path.
Contributor
Author
|
superseded by #30571 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lucene IW checks for pending deletes before it starts. In the
split / shrink case we might delete files which can cause this
check to trip. Since we know that these files are not subject for
reusal we can use a private directory instance for this operation
to prevent unnecessary busy waiting but still keep the checks for
subsequent useage.
Closes #30416