Skip to content

Conversation

@lukens
Copy link

@lukens lukens commented May 10, 2018

Changed InetSocketTransportAddress to TransportAddress, as that seems to be the thing now.

Changed `InetSocketTransportAddress` to `TransportAddress`, as that seems to be  the thing now.
@colings86 colings86 added the >docs General docs changes label May 11, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@colings86 colings86 added the :Search/Search Search-related issues that do not fall into other categories label May 11, 2018
@colings86 colings86 requested a review from martijnvg May 11, 2018 12:14
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukens for catching this. It looks like the code example is out of date for the 6.x branches since the InetSocketTransportAddress was removed in #20695
I will update this accordingly.

@cbuescher cbuescher self-assigned this May 15, 2018
@cbuescher
Copy link
Member

@elasticmachine test this please

@cbuescher cbuescher merged commit bc5f54b into elastic:6.2 May 16, 2018
cbuescher pushed a commit that referenced this pull request May 16, 2018
Changed `InetSocketTransportAddress` to `TransportAddress`, as that 
seems to be  the thing now.
cbuescher pushed a commit that referenced this pull request May 16, 2018
Changed `InetSocketTransportAddress` to `TransportAddress`, as that 
seems to be  the thing now.
cbuescher pushed a commit that referenced this pull request May 16, 2018
Changed `InetSocketTransportAddress` to `TransportAddress`, as that 
seems to be  the thing now.
cbuescher pushed a commit that referenced this pull request May 16, 2018
Changed `InetSocketTransportAddress` to `TransportAddress`, as that 
seems to be  the thing now.
cbuescher pushed a commit that referenced this pull request May 16, 2018
Changed `InetSocketTransportAddress` to `TransportAddress`, as that 
seems to be  the thing now.
@cbuescher
Copy link
Member

@lukens thanks for this correction, it is merged to master and all 6.x branches now.

@bleskes bleskes added v6.3.0 and removed v6.3.1 labels May 16, 2018
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 16, 2018
…bad-mkay

* elastic/6.x:
  [ML] Wait for ML indices in rolling upgrade tests (elastic#30615)
  Watcher: Ensure secrets integration tests also run triggered watch (elastic#30478)
  Move allocation awareness attributes to list setting (elastic#30626)
  [Docs] Update code snippet in has-child-query.asciidoc (elastic#30510)
  Allow date math for naming newly-created snapshots (elastic#7939) (elastic#30479)
  Awaits fix a failing test
  Switch many QA projects to use new style requests (elastic#30574)
  QA: System property to override distribution (elastic#30591)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 16, 2018
…ngs-to-true

* elastic/master: (34 commits)
  Test: increase search logging for LicensingTests
  Adjust serialization version in IndicesOptions
  [TEST] Fix compilation
  Remove version argument in RangeFieldType (elastic#30411)
  Remove unused DirectoryUtils class. (elastic#30582)
  Mitigate date histogram slowdowns with non-fixed timezones. (elastic#30534)
  Add a MovingFunction pipeline aggregation, deprecate MovingAvg agg (elastic#29594)
  Removes AwaitsFix on IndicesOptionsTests
  Template upgrades should happen in a system context (elastic#30621)
  Fix bug in BucketMetrics path traversal (elastic#30632)
  Fixes IndiceOptionsTests to serialise correctly (elastic#30644)
  S3 repo plugin populate SettingsFilter (elastic#30652)
  mute IndicesOptionsTests.testSerialization
  Rest High Level client: Add List Tasks (elastic#29546)
  Refactors ClientHelper to combine header logic (elastic#30620)
  [ML] Wait for ML indices in rolling upgrade tests (elastic#30615)
  Watcher: Ensure secrets integration tests also run triggered watch (elastic#30478)
  Move allocation awareness attributes to list setting (elastic#30626)
  [Docs] Update code snippet in has-child-query.asciidoc (elastic#30510)
  Replace custom reloadable Key/TrustManager (elastic#30509)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :Search/Search Search-related issues that do not fall into other categories v6.0.3 v6.1.5 v6.2.5 v6.3.0 v6.4.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants