[CCR] Add validation checks that were left out of #30120 #30463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
review
:Distributed Indexing/CCR
Collaborator
|
Pinging @elastic/es-distributed |
dnhatn
reviewed
May 10, 2018
Member
There was a problem hiding this comment.
@martijnvg index.soft_deletes has been renamed to index.soft_deletes.enabled as we have one more setting under this group.
martijnvg
force-pushed
the
ccr_more_validation
branch
from
c176b67 to
80f5ccb
Compare
Member
Author
|
@jasontedor @dnhatn I've updated this PR. |
* es/ccr: (37 commits) Default to one shard (elastic#30539) Unmute IndexUpgradeIT tests Forbid expensive query parts in ranking evaluation (elastic#30151) Docs: Update HighLevelRestClient migration docs (elastic#30544) Clients: Switch to new performRequest (elastic#30543) [TEST] Fix typo in MovAvgIT test Add missing dependencies on testClasses (elastic#30527) [TEST] Mute ML test that needs updating to following ml-cpp changes Document woes between auto-expand-replicas and allocation filtering (elastic#30531) Moved tokenizers to analysis common module (elastic#30538) Adjust copy settings versions Mute ShrinkIndexIT suite SQL: SYS TABLES ordered according to *DBC specs (elastic#30530) Deprecate not copy settings and explicitly disallow (elastic#30404) [ML] Improve state persistence log message Build: Add mavenPlugin cluster configuration method (elastic#30541) Re-enable FlushIT tests Bump Gradle heap to 2 GB (elastic#30535) SQL: Use request flavored methods in tests (elastic#30345) Suppress hdfsFixture if there are spaces in the path (elastic#30302) ...
jasontedor
approved these changes
May 16, 2018
| } | ||
| } | ||
|
|
||
| private static IndexMetaData createIMD(String index, int numShards, String... settings) { |
Member
There was a problem hiding this comment.
Would Tuple<String, String>... be claaner? Then you can side-step the modulo check, and you can iterate over pairs which is more natural for what you're doing here?
martijnvg
added a commit
that referenced
this pull request
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting before #30120 is merged.