From d426677ea317cfadc66343463f095b0c6ef88b43 Mon Sep 17 00:00:00 2001 From: Jason Tedor Date: Wed, 2 May 2018 09:49:45 -0400 Subject: [PATCH 1/2] Disable SSL on testing old BWC nodes Old versions of Elasticsearch with SSL have a problem due to a bug in Netty where an illegal reference count exception can cause the cluster to fall apart. This issue impacted Netty 4.1.5.Final and 4.1.6.Final. With: for tag in $(git tag | grep -E 'v5\.[0-9]\.[0-9]$') do echo -n "$tag " \ && git show $tag:modules/transport-netty4/build.gradle \ | grep netty-buffer \ | cut -d: -f3 \ | perl -p -e 's/"$//g' done v5.0.0 4.1.5.Final v5.0.1 4.1.5.Final v5.0.2 4.1.5.Final v5.1.1 4.1.6.Final v5.1.2 4.1.6.Final v5.2.0 4.1.7.Final v5.2.1 4.1.7.Final v5.2.2 4.1.7.Final v5.3.0 4.1.7.Final v5.3.1 4.1.7.Final v5.3.2 4.1.7.Final v5.3.3 4.1.7.Final v5.4.0 4.1.9.Final v5.4.1 4.1.11.Final v5.4.2 4.1.11.Final v5.4.3 4.1.11.Final v5.5.0 4.1.11.Final v5.5.1 4.1.11.Final v5.5.2 4.1.11.Final v5.5.3 4.1.11.Final v5.6.0 4.1.13.Final v5.6.1 4.1.13.Final v5.6.2 4.1.13.Final v5.6.3 4.1.13.Final v5.6.4 4.1.13.Final v5.6.5 4.1.13.Final v5.6.6 4.1.13.Final v5.6.7 4.1.13.Final v5.6.8 4.1.13.Final v5.6.9 4.1.13.Final We see that this means we need to not use SSL when testing nodes before 5.2.1. That is what this commit does. --- x-pack/qa/full-cluster-restart/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/qa/full-cluster-restart/build.gradle b/x-pack/qa/full-cluster-restart/build.gradle index 6750cf0a7dcc0..45408dd3e4abc 100644 --- a/x-pack/qa/full-cluster-restart/build.gradle +++ b/x-pack/qa/full-cluster-restart/build.gradle @@ -163,7 +163,7 @@ subprojects { setting 'logger.level', 'DEBUG' setting 'xpack.security.enabled', 'true' - setting 'xpack.security.transport.ssl.enabled', 'true' + setting 'xpack.security.transport.ssl.enabled', version.onOrAfter("5.2.1").toString() setting 'xpack.ssl.keystore.path', 'testnode.jks' setting 'xpack.ssl.keystore.password', 'testnode' if (version.onOrAfter('6.3.0')) { From e5d039d240801b26e1c69d23ad5b62e2a4c14122 Mon Sep 17 00:00:00 2001 From: Jason Tedor Date: Wed, 2 May 2018 09:59:39 -0400 Subject: [PATCH 2/2] Fix version --- x-pack/qa/full-cluster-restart/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/qa/full-cluster-restart/build.gradle b/x-pack/qa/full-cluster-restart/build.gradle index 45408dd3e4abc..fbef056b34738 100644 --- a/x-pack/qa/full-cluster-restart/build.gradle +++ b/x-pack/qa/full-cluster-restart/build.gradle @@ -163,7 +163,7 @@ subprojects { setting 'logger.level', 'DEBUG' setting 'xpack.security.enabled', 'true' - setting 'xpack.security.transport.ssl.enabled', version.onOrAfter("5.2.1").toString() + setting 'xpack.security.transport.ssl.enabled', version.onOrAfter("5.2.0").toString() setting 'xpack.ssl.keystore.path', 'testnode.jks' setting 'xpack.ssl.keystore.password', 'testnode' if (version.onOrAfter('6.3.0')) {