[DOCS] Removes X-Pack Elasticsearch release notes #30272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Sue-Gallagher
left a comment
Sue-Gallagher
left a comment
There was a problem hiding this comment.
In docs/CHANGELOG.asciidoc - Security paragrahp:
- Begin paragraph with condition - "If field-level security is enabled, ..."
- Line 30 - are we missing a serial comma and another 'get'? - "...get field mappings(,) and (get?) field capabilities ...
- Line 30 - API -> APIs
or:
"...capabilities are now the only APIs that the user..."
Contributor
Author
|
@Sue-Gallagher You're right, that security item is unclear. I'll need to follow up with the PR owner to determine the actual meaning of that sentence, but I'll make any follow-up changes in a separate PR. This PR just merges the existing text into the new changelog file. |
dnhatn
added a commit
that referenced
this pull request
May 2, 2018
* master: (68 commits) [DOCS] Removes X-Pack Elasticsearch release notes (#30272) Correct an example in the top-level suggester documentation. (#30224) [DOCS] Removes broken link [DOCS] Adds file realm configuration details (#30221) [DOCS] Adds PKI realm configuration details (#30225) Fix a reference to match_phrase_prefix in the match query docs. (#30282) Fix failure for validate API on a terms query (#29483) [DOCS] Fix 6.4-specific link in changelog (#30314) Remove RepositoriesMetaData variadic constructor (#29569) Test: increase authentication logging for debugging [DOCS] Removes redundant SAML realm settings (#30196) REST Client: Add Request object flavored methods (#29623) [DOCS] Adds changelog to Elasticsearch Reference (#30271) [DOCS] Fixes section error SQL: Teach the CLI to ignore empty commands (#30265) [DOCS] Adds Active Directory realm configuration details (#30223) [DOCS] Removes redundant file realm settings (#30192) [DOCS] Fixes users command name (#30275) Build: Move gradle wrapper jar to a dot dir (#30146) Build: Log a warning if disabling reindex-from-old (#30304)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the "X-Pack Elasticsearch Release Notes" from the Elasticsearch Reference and moves the existing content into the CHANGELOG.asciidoc file.
Related to #29450