Skip to content

Improve docs for disk watermarks #30249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2018
Merged

Improve docs for disk watermarks #30249

merged 2 commits into from
Apr 30, 2018

Conversation

@DaveCTurner
Copy link
Contributor

@DaveCTurner DaveCTurner commented Apr 30, 2018 •
edited
Loading

  • Clarify that the low watermark does not affect brand-new shards.
  • Replace ES -> Elasticsearch.
  • Format to 80 columns.

Resolves #25163

@DaveCTurner
Improve docs for disk watermarks
d7197e9 
* Clarify that the low watermark does not affect brand-new shards.
* Replace ES -> Elasticsearch.
* Format to 80 columns.

Resolves elastic#25163
@DaveCTurner DaveCTurner added >docs General docs changes v7.0.0 v6.0.3 :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) v6.1.5 v6.2.5 v6.4.0 v6.3.1 labels Apr 30, 2018
@DaveCTurner DaveCTurner requested a review from ywelsch April 30, 2018 08:49
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 30, 2018

Pinging @elastic/es-distributed

ywelsch
ywelsch approved these changes Apr 30, 2018
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (one optional suggestion)

docs/reference/modules/cluster/disk_allocator.asciidoc Outdated
85% disk used. It can also be set to an absolute byte value (like `500mb`)
to prevent Elasticsearch from allocating shards if less than the specified
amount of space is available. This setting has no effect on brand-new
shards that have never been allocated before.
Copy link
Contributor

@ywelsch ywelsch Apr 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this a little bit more explicit, I would add something along the lines of ", for example when a new index is created".

Copy link
Contributor Author

@DaveCTurner DaveCTurner Apr 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to

This setting has no effect on the primary shards of newly-created indices or, specifically, any shards that have never previously been allocated.

WDYT?

Copy link
Contributor

@ywelsch ywelsch Apr 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@DaveCTurner DaveCTurner merged commit d553a8b into elastic:master Apr 30, 2018
@DaveCTurner DaveCTurner deleted the 2018-04-30-watermark-docs branch April 30, 2018 16:31
DaveCTurner added a commit that referenced this pull request Apr 30, 2018
@DaveCTurner
Improve docs for disk watermarks (#30249)
00f272e 
* Clarify that the low watermark does not affect brand-new shards.
* Replace ES -> Elasticsearch.
* Format to 80 columns.

Resolves #25163
DaveCTurner added a commit that referenced this pull request Apr 30, 2018
@DaveCTurner
Improve docs for disk watermarks (#30249)
136a981 
* Clarify that the low watermark does not affect brand-new shards.
* Replace ES -> Elasticsearch.
* Format to 80 columns.

Resolves #25163
DaveCTurner added a commit that referenced this pull request Apr 30, 2018
@DaveCTurner
Improve docs for disk watermarks (#30249)
99b3859 
* Clarify that the low watermark does not affect brand-new shards.
* Replace ES -> Elasticsearch.
* Format to 80 columns.

Resolves #25163
DaveCTurner added a commit that referenced this pull request Apr 30, 2018
@DaveCTurner
Improve docs for disk watermarks (#30249)
4c9e2dd 
* Clarify that the low watermark does not affect brand-new shards.
* Replace ES -> Elasticsearch.
* Format to 80 columns.

Resolves #25163
DaveCTurner added a commit that referenced this pull request Apr 30, 2018
@DaveCTurner
Improve docs for disk watermarks (#30249)
62852a1 
* Clarify that the low watermark does not affect brand-new shards.
* Replace ES -> Elasticsearch.
* Format to 80 columns.

Resolves #25163
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 1, 2018
@jasontedor
Merge remote-tracking branch 'origin/master' into resize-settings
c7571ec 
* origin/master:
  [test] add java packaging test project (elastic#30161)
  Fix macros in changelog (elastic#30269)
  [DOCS] Fixes syskeygen command name
  [ML] Include 3rd party C++ component notices (elastic#30132)
  _cluster/state Skip Test for pre-6.4, not pre-7.0 (elastic#30264)
  Improve docs for disk watermarks (elastic#30249)
  [DOCS] Removes redundant Active Directory realm settings (elastic#30190)
  [DOCS] Removes redundant LDAP realm settings (elastic#30193)
  _cluster/state should always return cluster_uuid (elastic#30143)
  HTML5ify Javadoc for core and test framework (elastic#30234)
  Minor tweaks to reroute documentation (elastic#30246)
@bleskes bleskes added v6.3.0 and removed v6.3.1 labels May 1, 2018
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ywelsch ywelsch ywelsch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >docs General docs changes v6.0.3 v6.1.5 v6.2.5 v6.3.0 v6.4.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DaveCTurner @elasticmachine @ywelsch @bleskes @jimczi