[DOCS] Removes redundant LDAP realm settings #30193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
>docs
lcawl
changed the title
jaymode
approved these changes
Apr 27, 2018
Member
jaymode
left a comment
jaymode
left a comment
There was a problem hiding this comment.
I left a couple of suggestions, other than those LGTM
Member
There was a problem hiding this comment.
good catch. Maybe The attribute to match with the username sent with the request or username provided for authentication
Member
There was a problem hiding this comment.
Maybe we should say a hash of its credentials to more accurately represent what is being cached
lcawl
force-pushed
the
lcawley-ldaprealmsettings
branch
from
35b8081 to
164f1e5
Compare
Contributor
Author
|
Thanks, @jaymode I've implemented those changes. |
hub-cap
added
:Security/Authentication
Collaborator
|
Pinging @elastic/es-security |
jaymode
approved these changes
Apr 30, 2018
lcawl
added a commit
that referenced
this pull request
Apr 30, 2018
lcawl
added a commit
that referenced
this pull request
Apr 30, 2018
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 1, 2018
* origin/master: [test] add java packaging test project (elastic#30161) Fix macros in changelog (elastic#30269) [DOCS] Fixes syskeygen command name [ML] Include 3rd party C++ component notices (elastic#30132) _cluster/state Skip Test for pre-6.4, not pre-7.0 (elastic#30264) Improve docs for disk watermarks (elastic#30249) [DOCS] Removes redundant Active Directory realm settings (elastic#30190) [DOCS] Removes redundant LDAP realm settings (elastic#30193) _cluster/state should always return cluster_uuid (elastic#30143) HTML5ify Javadoc for core and test framework (elastic#30234) Minor tweaks to reroute documentation (elastic#30246)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the redundant information about LDAP realm settings from
https://www.elastic.co/guide/en/elastic-stack-overview/master/ldap-realm.html
after integrating the missing information in
https://www.elastic.co/guide/en/elasticsearch/reference/master/security-settings.html#ref-ldap-settings