Updated the keys in the percentile aggregation tests to be strings #27355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmi
force-pushed
the
karmi/fix_agg_percentile_tests
branch
from
9c09741 to
8ee27da
Compare
Merged
Collaborator
|
Pinging @elastic/es-search-aggs |
Contributor
|
@karmi are you picking this one up? |
Contributor
Author
|
@bleskes , argh, went totally under my radar, I'll look into it... |
Member
|
@karmi could you take a look at the current version on master that is in conflict with this PR please? It changed the match clauses so I'm not sure anymore if your PR still makes sense or can be closed (don't know how the ruby test runner works with the current style) |
Contributor
Author
|
I will, I’m on vacation since last week, so when I get back to the computer! :)
…--
Sent on the go
On 8 May 2018, at 13:49, Christoph Büscher ***@***.***> wrote:
@karmi could you take a look at the current version on master that is in conflict with this PR please? It changed the match clauses so I'm not sure anymore if your PR still makes sense or can be closed (don't know how the ruby test runner works with the current style)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
Author
|
I'm going to close this for now indeed — I'll create a fresh PR from master if I'd run into the issue again. Thanks for the ping @bleskes and @cbuescher ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following in the path of #26905, this patch updates another set of keys
to be strings instead of numbers, otherwise the Ruby runner fails.