migrate some MasterNodeRequest subclasses to Writeable Readers #26463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
:Core/Infra/Core
nik9000
approved these changes
Sep 1, 2017
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
Other than the leftover I think this is good.
Contributor
Author
There was a problem hiding this comment.
oh me oh my. indeed. I was debugging. will remove. thanks!
Member
There was a problem hiding this comment.
If you add // nocommit any time that you add a debug line like this, the build will help you remember to remove it (a pre-commit check will fail).
Contributor
Author
There was a problem hiding this comment.
thanks for the protip! I will
talevy
force-pushed
the
masternodewriteable
branch
from
2bf37df to
4821aeb
Compare
talevy
force-pushed
the
masternodewriteable
branch
from
4821aeb to
6db927e
Compare
Contributor
Author
|
merging even though build failed. Build failed due to bwc tests thinking 6.0-beta2 is the current 6.0 build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrating more classes to implement Writeable.Reader functional interfaces
and deprecate Streamable's readFrom.
The main goal for this PR is to help transition the MasterNodeRequest subclassed request objects. Since there are more than I'd like to count, more will follow in another PR.
AcknowledgedRequests will be next