Remove index.mapping.single_type=false from reindex tests
#25365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the setting from the yml tests and replace with tests using `join` field. We can't use the setting in yml tests without lots of backflips but we have `ReindexParentChildTests` for the coverage. There weren't tests for `join` field with reindex before this. Adding these tests discovered elastic#25363. * Remove the setting from `ReindexParentChildTests` and replace with `index.version.created=V_5_6_0`. This test can be entirely removed when legacy parent/child support is dropped from core. Relates to elastic#24961
nik9000
added
:Reindex API
>test
Member
Author
|
Woops. Found another one. One moment. |
* Port the yml tests that set _parent into integ tests so they can set the index created version. These tests can be removed when we drop support for _parent in core.
* Port a delete-by-query test for filtering based on type to an `ESIntegTestCase` so it can use `index.version.created=5.6.0` to setup documents of multiple types. This whole feature can be dropped when we no longer support multiple types per index.
Member
Author
|
Ok. All cleaned up. I found the parent/child tests first and didn't notice the others. |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jun 26, 2017
* master: Move more token filters to analysis-common module Test: Allow merging mock secure settings (elastic#25387) Remove remaining `index.mapper.single_type` setting usage from tests (elastic#25388) Remove dead logger prefix code Tests: Improve stability and logging of TemplateUpgradeServiceIT tests (elastic#25386) Remove `index.mapping.single_type=false` from reindex tests (elastic#25365) Adapt `SearchIT#testSearchWithParentJoin` to new join field (elastic#25379) Added unit test coverage for SignificantTerms (elastic#24904)
lcawl
added
:Distributed Indexing/CRUD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
joinfield. We can't use the setting in yml tests without lots ofbackflips but we have
ReindexParentChildTestsfor the coverage.There weren't tests for
joinfield with reindex before this. Addingthese tests discovered Reindex from remote doesn't work with master's
joinmodule #25363.ReindexParentChildTestsand replace withindex.version.created=5.6.0. This test can be entirely removedwhen legacy parent/child support is dropped from core.
can set the index created version. These tests can be removed
when we drop support for _parent in core.
ESIntegTestCaseso it can useindex.version.created=5.6.0tosetup documents of multiple types. This whole feature can be dropped
when we no longer support multiple types per index.
Relates to #24961