Remove redundant and broken MD5 checksum from repository-s3 #25270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Checksums are calculated and compared by the S3 client already. elastic#25269
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
… S3 repository check-summing
Member
|
@dadoonet You probably know the most about this? |
clintongormley
added
:Distributed Coordination/Snapshot/Restore
Contributor
Author
|
@abeyad, did you have a chance to have a look? Thanks. |
abeyad
approved these changes
Jun 21, 2017
abeyad
left a comment
abeyad
left a comment
There was a problem hiding this comment.
LGTM, great find @joachimdraeger ! Thank you for reporting and fixing it.
abeyad
pushed a commit
that referenced
this pull request
Jun 21, 2017
Remove redundant and not resettable (fails on retries) check-summing. Checksums are calculated and compared by the S3 client already. Closes #25269
abeyad
pushed a commit
that referenced
this pull request
Jun 21, 2017
Remove redundant and not resettable (fails on retries) check-summing. Checksums are calculated and compared by the S3 client already. Closes #25269
abeyad
pushed a commit
that referenced
this pull request
Jun 21, 2017
Remove redundant and not resettable (fails on retries) check-summing. Checksums are calculated and compared by the S3 client already. Closes #25269
Contributor
Author
|
Thanks for your review and merge, @abeyad |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jun 22, 2017
* master: (56 commits) Initialize max unsafe auto ID timestamp on shrink Enable a long translog retention policy by default (elastic#25294) Remove `index.mapping.single_type=false` from core/tests (elastic#25331) test: single type defaults to true since alpha1 and not alpha3 Get short path name for native controllers Live primary-replica resync (no rollback) (elastic#24841) Upgrade to lucene-7.0.0-snapshot-ad2cb77. (elastic#25349) percolator: Deprecate `document_type` parameter. [DOCS] Fixed typo. [rest-api-spec/indices.refresh] Remove old params Remove redundant and broken MD5 checksum from repository-s3 (elastic#25270) Initialize sequence numbers on a shrunken index Port most snapshot/restore static bwc tests to qa:full-cluster-restart (elastic#25296) Javadoc: ThreadPool doesn't reject while shutdown (elastic#23678) test: verify `size_to_upgrade_in_bytes` in assertBusy(...) Docs: Removed duplicated line in mapping docs Add backward compatibility indices for 5.4.2 Update MockTransportService to the age of Transport.Connection (elastic#25320) Add version v5.4.2 after release IndexMetaData: Add internal format index setting (elastic#25292) ...
utkarshsins
pushed a commit
to rahulanishetty/elasticsearch
that referenced
this pull request
Jun 29, 2017
…25270) Remove redundant and not resettable (fails on retries) check-summing. Checksums are calculated and compared by the S3 client already. Closes elastic#25269
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant and not resettable (fails on retries) check-summing. Checksums are calculated and compared by the S3 client already. #25269