Add more unit tests for terms aggregation #24949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
:Analytics/Aggregations
63 tasks
jpountz
reviewed
May 30, 2017
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
The new tests look good but I'm not totally comfortable with removing the integ tests yet.
jpountz
approved these changes
May 30, 2017
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
Actually I just discussed it with Martijn and I think his approach is right: the actual integ tests for aggs should be rest tests.
removed terms agg integration tests that were replaced by unit tests.
martijnvg
force-pushed
the
TermsAggregatorTests
branch
from
0defcc6 to
a089dc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and removed terms agg java integ tests that were replaced by unit tests.
Relates to #22278