Added unit test coverage for SignificantTerms #24904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markharwood
added
:Analytics/Aggregations
colings86
reviewed
May 30, 2017
Contributor
colings86
left a comment
colings86
left a comment
There was a problem hiding this comment.
I think we should add some of the tests from the removed integration test suite. Specifically I think we should test with include/exclude, with a different heuristic and unmapped/partially unmapped fields
63 tasks
Member
|
@markharwood Do you want to address Colin's feedback and get this in? |
Contributor
Author
|
Looking at this now |
markharwood
force-pushed
the
fix/22278sig_terms
branch
from
361a85f to
f16ad5a
Compare
Contributor
Author
|
@colings86 Care to take another look? |
colings86
approved these changes
Jun 21, 2017
Contributor
colings86
left a comment
colings86
left a comment
There was a problem hiding this comment.
Left one comment but LGTM
Contributor
There was a problem hiding this comment.
should we check that the number of buckets returned is zero instead to ensure nothing weird is going on?
markharwood
force-pushed
the
fix/22278sig_terms
branch
from
f16ad5a to
b504815
Compare
…, GlobalOrdinalsSignificantTermsAggregator.WithHash, SignificantLongTermsAggregator and SignificantStringTermsAggregator Removed integration test Relates elastic#22278
…ound_filter. Requested include/exclude tests already exist in this unit test.
…us check on number of segments which was recently causing issues in SignificantTextAggregatorTests
markharwood
force-pushed
the
fix/22278sig_terms
branch
from
b504815 to
402f62a
Compare
Contributor
Author
|
jenkins test this |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jun 26, 2017
* master: Move more token filters to analysis-common module Test: Allow merging mock secure settings (elastic#25387) Remove remaining `index.mapper.single_type` setting usage from tests (elastic#25388) Remove dead logger prefix code Tests: Improve stability and logging of TemplateUpgradeServiceIT tests (elastic#25386) Remove `index.mapping.single_type=false` from reindex tests (elastic#25365) Adapt `SearchIT#testSearchWithParentJoin` to new join field (elastic#25379) Added unit test coverage for SignificantTerms (elastic#24904)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers GlobalOrdinalsSignificantTermsAggregator, GlobalOrdinalsSignificantTermsAggregator.WithHash, SignificantLongTermsAggregator and SignificantStringTermsAggregator
Removed integration test
Relates #22278