Skip to content

Conversation

@polyfractal
Copy link
Contributor

If the bucket already exists, due to non-overlapping series or missing data, the MovAvg creates a merged bucket with the existing aggs + the new prediction. This fixes a small bug where the doc_count was not being set correctly.

Relates to #24327

…kets

If the bucket already exists, due to non-overlapping series or missing data, the
MovAvg creates a merged bucket with the existing aggs + the new prediction.  This
fixes a small bug where the doc_count was not being set correctly.

Relates to elastic#24327
Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polyfractal polyfractal merged commit b8d7b83 into elastic:master May 30, 2017
@polyfractal polyfractal added v6.0.0 and removed review labels May 30, 2017
polyfractal added a commit that referenced this pull request May 30, 2017
…kets (#24892)

If the bucket already exists, due to non-overlapping series or missing data, the
MovAvg creates a merged bucket with the existing aggs + the new prediction.  This
fixes a small bug where the doc_count was not being set correctly.

Relates to #24327
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 30, 2017
* master:
  Fix typo in comment in ReplicationOperation.java
  Prevent Index & Delete request primaryTerm getter/setter, setShardId setter
  Drop name from TokenizerFactory (elastic#24869)
  Correctly set doc_count when MovAvg "predicts" values on existing buckets (elastic#24892)
  Handle primary failure handling replica response
  Add missing word to terms-query.asciidoc (elastic#24960)
  Correct some spelling in match-phrase-prefix docs (elastic#24956)
  testConcurrentWriteViewsAndSnapshot shouldn't flush concurrently
  [TEST] Fix FieldSortIT failures
  Add doc_count to ParsedMatrixStats (elastic#24952)
  Add document count to Matrix Stats aggregation response (elastic#24776)
  Fix script field sort returning Double.MAX_VALUE for all documents (elastic#24942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants