Add document count to Matrix Stats aggregation response #24776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a `doc_count` field to the response body of Matrix Stats aggregation. It exposes the number of documents involved in the computation of statistics, a value that can already be retrieved using the method MatrixStats.getDocCount() in the Java API.
javanna
approved these changes
May 19, 2017
Member
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
LGTM I think this is useful to REST clients in general as this info was only returned through transport.
Member
Author
|
Thanks @javanna |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
May 30, 2017
This commit adds support in ParsedMatrixStats for parsing the doc_count field. Related to elastic#24776
tlrx
added a commit
that referenced
this pull request
May 30, 2017
This commit adds support in ParsedMatrixStats for parsing the doc_count field. Related to #24776
tlrx
added a commit
that referenced
this pull request
May 30, 2017
This commit adds a `doc_count` field to the response body of Matrix Stats aggregation. It exposes the number of documents involved in the computation of statistics, a value that can already be retrieved using the method MatrixStats.getDocCount() in the Java API.
tlrx
added a commit
that referenced
this pull request
May 30, 2017
This commit adds support in ParsedMatrixStats for parsing the doc_count field. Related to #24776
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 30, 2017
* master: Fix typo in comment in ReplicationOperation.java Prevent Index & Delete request primaryTerm getter/setter, setShardId setter Drop name from TokenizerFactory (elastic#24869) Correctly set doc_count when MovAvg "predicts" values on existing buckets (elastic#24892) Handle primary failure handling replica response Add missing word to terms-query.asciidoc (elastic#24960) Correct some spelling in match-phrase-prefix docs (elastic#24956) testConcurrentWriteViewsAndSnapshot shouldn't flush concurrently [TEST] Fix FieldSortIT failures Add doc_count to ParsedMatrixStats (elastic#24952) Add document count to Matrix Stats aggregation response (elastic#24776) Fix script field sort returning Double.MAX_VALUE for all documents (elastic#24942)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
doc_countfield to the response body of Matrix Stats aggregation. It exposes the number of documents involved in the computation of statistics, a value that can already be retrieved usingthe method
MatrixStats.getDocCount()in the Java API.This information will be useful for the Java High Level Rest Client in order to provide the same level of information as what a user can get using the Transport Client (see #24746 (comment)).