Remove the unused SignificantTerms.compareTerm() method #24714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is not used and not tested. While it exists it forces implementations of the interface to implement it while it's unused.
tlrx
added
:Analytics/Aggregations
tlrx
added a commit
that referenced
this pull request
May 18, 2017
This method is not used and not tested. While it exists it forces implementations of the interface to implement it while it's unused.
tlrx
added a commit
that referenced
this pull request
May 19, 2017
This method has been removed in core (see #24714)
javanna
pushed a commit
to javanna/elasticsearch
that referenced
this pull request
May 23, 2017
This method has been removed in core (see elastic#24714)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is not used and not tested. But it existence forces implementations of the interface to implement it even if it's unused.