Add parsing for InternalFilters aggregation #24648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
force-pushed
the
addParsing-InternalFilters
branch
from
82706dd to
4cd2190
Compare
javanna
approved these changes
May 12, 2017
Member
There was a problem hiding this comment.
I am not sure, but shall we do this eagerly rather than on demand?
Member
Author
There was a problem hiding this comment.
I don't mind, this is the way it is done in InternalFilters currently, thats why I kept it.
Member
There was a problem hiding this comment.
mention here too that this is what we do also in the corresponding builder
This adds parsing to the InternalFilters aggregation.
cbuescher
force-pushed
the
addParsing-InternalFilters
branch
from
4cd2190 to
86ed37a
Compare
This was referenced May 15, 2017
javanna
pushed a commit
to javanna/elasticsearch
that referenced
this pull request
May 23, 2017
This adds parsing to the InternalFilters aggregation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds parsing to the InternalFilters aggregation.