AbstractParsedPercentiles should use Percentile class #24160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the Percentile interface has been merged with the InternalPercentile class in core (elastic#24154) the AbstractParsedPercentiles should use it. This commit also changes InternalPercentilesRanksTestCase so that it now tests the iterator obtained from parsed percentiles ranks aggregations. Adding this new test raised an issue in the iterators where key and value are "swapped" in internal implementations when building the iterators (see InternalTDigestPercentileRanks.Iter constructor that accepts the `keys` as the first parameter named `values`, each key being mapped to the `value` field of Percentile class). This is because percentiles ranks aggs inverts percentiles/values compared to the percentiles aggs.
tlrx
added
:Java High Level REST Client
>test
javanna
reviewed
Apr 18, 2017
| public final void testFromXContent() throws IOException { | ||
| final NamedXContentRegistry xContentRegistry = xContentRegistry(); | ||
| final T aggregation = createTestInstance(); | ||
| assumeTrue("This test does not support the aggregation type yet", |
Member
There was a problem hiding this comment.
leave the //norelease ? we will have to get rid of it at some point.
javanna
reviewed
Apr 18, 2017
| final NamedXContentRegistry xContentRegistry = xContentRegistry(); | ||
| final T aggregation = createTestInstance(); | ||
| assumeTrue("This test does not support the aggregation type yet", | ||
| getNamedXContents().stream().filter(entry -> entry.name.match(aggregation.getType())).count() == 1); |
Member
There was a problem hiding this comment.
count > 0? just being paranoid :)
javanna
reviewed
Apr 18, 2017
| final boolean keyed = randomBoolean(); | ||
| final DocValueFormat format = randomFrom(DocValueFormat.RAW, new DocValueFormat.Decimal("###.##")); | ||
| List<Double> randomCdfValues = randomSubsetOf(randomIntBetween(1, 5), 0.01d, 0.05d, 0.25d, 0.50d, 0.75d, 0.95d, 0.99d); | ||
| List<Double> randomCdfValues = Collections.singletonList(0.75d);//randomSubsetOf(randomIntBetween(1, 5), 0.01d, 0.05d, 0.25d, 0.50d, 0.75d, 0.95d, 0.99d); |
Member
Author
|
Thanks @javanna I merged with your suggestions. I also had to move the test of iterators in a dedicated |
javanna
reviewed
Apr 18, 2017
| assertTrue(parsedClass.isInstance(parsedAggregation)); | ||
| } | ||
|
|
||
| public void testPercentilesRanksIterators() throws IOException { |
Member
There was a problem hiding this comment.
maybe some code could be shared, or maybe shuffling could be disabled optionally?
Member
Author
There was a problem hiding this comment.
I addressed this in #24183 where I added a parse() method that accepts a shuffled boolean.
javanna
pushed a commit
to javanna/elasticsearch
that referenced
this pull request
May 23, 2017
Now the Percentile interface has been merged with the InternalPercentile class in core (elastic#24154) the AbstractParsedPercentiles should use it. This commit also changes InternalPercentilesRanksTestCase so that it now tests the iterator obtained from parsed percentiles ranks aggregations. Adding this new test raised an issue in the iterators where key and value are "swapped" in internal implementations when building the iterators (see InternalTDigestPercentileRanks.Iter constructor that accepts the `keys` as the first parameter named `values`, each key being mapped to the `value` field of Percentile class). This is because percentiles ranks aggs inverts percentiles/values compared to the percentiles aggs. * Add assume in InternalAggregationTestCase * Update after Luca review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: pull request against feature branch
Now the Percentile interface has been merged with the InternalPercentile class in core (#24154) the AbstractParsedPercentiles should use it.
This commit also changes InternalPercentilesRanksTestCase so that it now tests the iterator obtained from parsed percentiles ranks aggregations.
Adding this new test raised an issue in the iterators where key and value are "swapped" in internal implementations when building the iterators (see InternalTDigestPercentileRanks.Iter constructor that accepts the
keysas the first parameter namedvalues, each key being mapped to thevaluefield of Percentile class). This is because percentiles ranks aggs inverts percentiles/values compared to the percentiles aggs.