Add unit tests for BinaryRangeAggregator/InternalBinaryRange #23255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimczi
added
:Analytics/Aggregations
jpountz
approved these changes
Feb 20, 2017
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
One comment about the hashcode impl, otherwise LGTM.
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(keyed, format, docCount, key, from, to, aggregations); |
Contributor
There was a problem hiding this comment.
keyed and format are in the hashcode but not in equals. I think it is fine not to consider them in equals since they only have an impact on formatting, but then hashCode should not use them either?
Contributor
|
LGTM |
63 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #22278