Skip to content

Add unit tests for DateHistogramAggregator #22714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2017
Merged

Add unit tests for DateHistogramAggregator #22714

merged 1 commit into from
Jan 20, 2017

Conversation

@tlrx
Copy link
Member

@tlrx tlrx commented Jan 20, 2017

Adds unit tests for the date histogram aggregator.

Relates #22278

@tlrx
Add unit tests for DateHistogramAggregator
e6584be 
Adds unit tests for the date histogram aggregator.

Relates elastic#22278
@tlrx tlrx added :Analytics/Aggregations Aggregations review >test Issues or PRs that are addressing/adding tests v5.3.0 v6.0.0-alpha1 labels Jan 20, 2017
@martijnvg martijnvg mentioned this pull request Jan 20, 2017
Closed
63 tasks
@tlrx
Copy link
Member Author

tlrx commented Jan 20, 2017

@jpountz you might be interested in reviewing this one (because in #22278 you've been assigned to HistogramAggregator unit tests)

@jimczi
Copy link
Contributor

jimczi commented Jan 20, 2017

LGTM

jpountz
jpountz approved these changes Jan 20, 2017
View reviewed changes
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlrx tlrx merged commit 239ed0c into elastic:master Jan 20, 2017
@tlrx tlrx deleted the add-unit-tests-for-date-histogram branch January 20, 2017 13:19
tlrx added a commit that referenced this pull request Jan 20, 2017
@tlrx
Add unit tests for DateHistogramAggregator (#22714)
f7dc7e2 
Adds unit tests for the date histogram aggregator.

Relates #22278
@tlrx
Copy link
Member Author

tlrx commented Jan 20, 2017

Thanks @jimczi @jpountz

@tlrx tlrx removed the review label Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jpountz jpountz jpountz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Analytics/Aggregations Aggregations >test Issues or PRs that are addressing/adding tests v5.3.0 v6.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tlrx @jimczi @jpountz