ingest-node.asciidoc - Clarify json processor #21876
Conversation
clintongormley
added
:Data Management/Ingest Node
|
@GlenRSmith LGTM, would be even nicer if these snippets used runnable CONSOLE snippets and included the docs tests (so we would actually confirm that the snippets run and that they return the result we're expecting) See https://github.com/elastic/elasticsearch/blob/master/docs/README.asciidoc for details |
|
@clintongormley Thanks for the explanatory link. I knew that feature was in play now, but nothing about implementation. This will be super helpful. But this PR failed some integration test? |
It was an unrelated failure, fixed by #21894. |
|
test again please |
2 similar comments
|
test again please |
|
test again please |
|
retest this please |
1 similar comment
|
retest this please |
|
@GlenRSmith, would you like to fix the merge conflict? |
|
|
||
| For example, if you have a log message which contains `ip=1.2.3.4 error=REFUSED`, you can parse those automatically by configuring: | ||
|
|
||
|
|
There was a problem hiding this comment.
Need to restore all the relevant markup around the examples in the kv processor.
(to get it back as it was)
|
retest this please |
|
Should pass now, but still needs snippets appropriately tagged for CONSOLE and TEST as commented by @clintongormley previously. |
|
I'd love to convert the snippets, yeah, but I don't think we need to block the merge on it. If the rest of the file were all CONSOLE and you were adding non-CONSOLE snippets, sure. If you think you'll have a chance to convert them then let me know and I'll wait. Otherwise I think we should merge to get the better docs and convert when we get around to it. I've been slowly converting the unconverted snippets and I'd get to these eventually. |
|
@nik9000 Then kindly merge away. I don't know when I would get to converting, and if I do get to it, well, it will be sitting there waiting. |
Add examples for the json processor.
Add examples for the json processor.
Add examples for the json processor.
|
OK @GlenRSmith! I've merged and cherry-picked to 5.x, 5.4, and 5.3. |
* master: Add BucketMetricValue interface (elastic#24188) Enable index-time sorting (elastic#24055) Clarify elasticsearch user uid:gid mapping in Docker docs Update field-names-field.asciidoc (elastic#24178) ElectMasterService.hasEnoughMasterNodes should return false if no masters were found Remove Ubuntu 12.04 (elastic#24161) [Test] Add unit tests for InternalHDRPercentilesTests (elastic#24157) Replicate write failures (elastic#23314) Rename variable in translog simple commit test Strengthen translog commit with open view test Stronger check in translog prepare and commit test Fix translog prepare commit and commit test ingest-node.asciidoc - Clarify json processor (elastic#21876) Painless: more testing for script_stack (elastic#24168)
Clarify documentation of json processor with a config, a sample doc, and the processed result