Skip to content

Reject DELETE requests with a body #21453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Reject DELETE requests with a body #21453

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98d6572
Reject DELETE requests with a body
bvolpato Nov 10, 2016
290c9a7
Exception message update
bvolpato Jan 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/main/java/org/elasticsearch/rest/action/document/RestDeleteAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ public RestDeleteAction(Settings settings, RestController controller) {

@Override
public RestChannelConsumer prepareRequest(final RestRequest request, final NodeClient client) throws IOException {
if (RestActions.hasBodyContent(request)) {
throw new IllegalArgumentException("DELETE requests may not contain a request body");
}

DeleteRequest deleteRequest = new DeleteRequest(request.param("index"), request.param("type"), request.param("id"));
deleteRequest.routing(request.param("routing"));
deleteRequest.parent(request.param("parent")); // order is important, set it after routing, so it will set the routing
Expand Down