Fixes leading forward slash in S3 repository base_path #20861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the repositories.s3.base_path, and it used a different string splitting method that removed the forward slash from the base path, so there were no issues. In 5.x, we removed this custom string splitting method in favor of the JDK's string splitting method, which preserved the leading `/`. The AWS SDK does not like the leading `/` in the key path after the bucket name, and so it could not find any objects in the S3 repository. This commit fixes the issue by removing the leading `/` if it exists and adding a deprecation notice that leading `/` will not be supported in the future in S3 repository's base_path.
Author
|
I created #20862 to ensure we have tests against real S3 repositories, which would uncover issues like this going forward. |
Member
|
LGTM |
rjernst
approved these changes
Oct 11, 2016
Author
|
thanks @rjernst |
abeyad
pushed a commit
that referenced
this pull request
Oct 11, 2016
In 2.x, the S3 repository accepted a `/` (forward slash) to start the repositories.s3.base_path, and it used a different string splitting method that removed the forward slash from the base path, so there were no issues. In 5.x, we removed this custom string splitting method in favor of the JDK's string splitting method, which preserved the leading `/`. The AWS SDK does not like the leading `/` in the key path after the bucket name, and so it could not find any objects in the S3 repository. This commit fixes the issue by removing the leading `/` if it exists and adding a deprecation notice that leading `/` will not be supported in the future in S3 repository's base_path.
abeyad
pushed a commit
that referenced
this pull request
Oct 11, 2016
In 2.x, the S3 repository accepted a `/` (forward slash) to start the repositories.s3.base_path, and it used a different string splitting method that removed the forward slash from the base path, so there were no issues. In 5.x, we removed this custom string splitting method in favor of the JDK's string splitting method, which preserved the leading `/`. The AWS SDK does not like the leading `/` in the key path after the bucket name, and so it could not find any objects in the S3 repository. This commit fixes the issue by removing the leading `/` if it exists and adding a deprecation notice that leading `/` will not be supported in the future in S3 repository's base_path.
Author
Contributor
|
thanks @abeyad |
clintongormley
added
:Distributed Coordination/Snapshot/Restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2.x, the S3 repository accepted a
/(forward slash) to startthe repositories.s3.base_path, and it used a different string splitting
method that removed the forward slash from the base path, so there
were no issues.
In 5.x, we removed this custom string splitting method in favor of
the JDK's string splitting method, which preserved the leading
/.The AWS SDK does not like the leading
/in the key path after thebucket name, and so it could not find any objects in the S3 repository.
This commit fixes the issue by removing the leading
/if it existsand adding a deprecation notice that leading
/will not be supportedin the future in S3 repository's base_path.