Skip to content

Conversation

@benwtrent
Copy link
Member

Version has been deprecated since v7: #74073

Removing checking for the version setting. It has been ignored and does nothing for the entirety of 8 and for the last minors of v7.

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Dec 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little hard to validate in review, a lot of things touched. But what I'm seeing here LGTM.

@benwtrent benwtrent added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Dec 6, 2024
@benwtrent
Copy link
Member Author

@elasticmachine update branch

@benwtrent
Copy link
Member Author

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit d614804 into elastic:main Dec 9, 2024
16 checks passed
@benwtrent benwtrent deleted the remove-deprecated-version-check branch December 9, 2024 20:30
@cbuescher
Copy link
Member

Re-visiting this PR for brief pulse check if we still want the deprecation warning for analysis components that use the "version" parameter. With the read-only N-2 index support we might encounter indices that use this setting in their analysis configuration. As far as I see we didn't do anything with it at least in most of the 7x releases, with the current state we would simply ignore the settings and be done with it.
If we want the deprecation warning back we can probably add it without having to carry all the settings objects around and move deprecation to somewhere more central (i.e. AnalysisRegistry#buildMapping or somewhere in that area).
@benwtrent if you're okay with the removal as is let me know, I was just checking this as part of re-visiting our decisions for v9 removal in light of the new N-2 support policy.

@benwtrent
Copy link
Member Author

@cbuescher I am fine keeping it removed these settings were deprecated in 7x, which is -2 v9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue :Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants