-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Remove analyzer version deprecation check #118167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove analyzer version deprecation check #118167
Conversation
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
john-wagster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little hard to validate in review, a lot of things touched. But what I'm seeing here LGTM.
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
Re-visiting this PR for brief pulse check if we still want the deprecation warning for analysis components that use the "version" parameter. With the read-only N-2 index support we might encounter indices that use this setting in their analysis configuration. As far as I see we didn't do anything with it at least in most of the 7x releases, with the current state we would simply ignore the settings and be done with it. |
|
@cbuescher I am fine keeping it removed these settings were deprecated in 7x, which is |
Version has been deprecated since v7: #74073
Removing checking for the version setting. It has been ignored and does nothing for the entirety of 8 and for the last minors of v7.