-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Description
Observed a failure on branch 6.8 for TranslogTests in #testStats:
| FAILURE 0.02s J15 \| TranslogTests.testStats <<< FAILURES! |
| > Throwable #1: java.lang.AssertionError: |
| > Expected: a value greater than <1L> |
| > but: <1L> was equal to <1L> |
| > at __randomizedtesting.SeedInfo.seed([6B2A44E9E0939A49:F1AB1D56884F546A]:0) |
| > at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) |
| > at org.elasticsearch.index.translog.TranslogTests.testStats(TranslogTests.java:439) |
| > at java.lang.Thread.run(Thread.java:748)
Reproduction line:
./gradlew ':server:unitTest' -Dtests.seed=6B2A44E9E0939A49 -Dtests.class=org.elasticsearch.index.translog.TranslogTests -Dtests.method="testStats" -Dtests.security.manager=true -Dtests.locale=ru -Dtests.timezone=SystemV/MST7MDT -Dcompiler.java=12 -Druntime.java=8
Unfortunately I wasn't able to reproduce after 50 iterations on the same operating system.
CI link: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.8+matrix-java-periodic/ES_RUNTIME_JAVA=adoptopenjdk8,nodes=general-purpose/622/console / https://gradle-enterprise.elastic.co/s/6xn7qjvruu5x6
Interestingly enough this is the first time if fails on 6.8, however, there were a number of failures on master in February that got fixed by #51905.
@dnhatn :
The specific line in 6.8 asserts >1 in
elasticsearch/server/src/test/java/org/elasticsearch/index/translog/TranslogTests.java
Line 439 in fe9394c
| assertThat(stats.getEarliestLastModifiedAge(), greaterThan(1L)); |
however, in #51905, we started asserting >0
elasticsearch/server/src/test/java/org/elasticsearch/index/translog/TranslogTests.java
Line 420 in 6d28596
| assertThat(stats.getEarliestLastModifiedAge(), greaterThan(0L)); |
Is there a reason for this difference?