Settings: Combining affix setting with group settings results in namespace issues

[spinscale]

Description of the problem including expected versus actual behavior:

When combining an affix setting with a group setting, the affix setting does not correctly find the namespaces anymore due to a non-working regex in Setting.AffixKey, when any setting inside that group setting is supplied

Steps to reproduce:

public void testAffixNamespacesWithGroupSetting() {
    final Setting.AffixSetting<Settings> affixSetting =
            Setting.affixKeySetting("prefix.","suffix",
                    (key) -> Setting.groupSetting(key + ".", Setting.Property.Dynamic, Setting.Property.NodeScope));

    // works
    assertThat(affixSetting.getNamespaces(Settings.builder().put("prefix.infix.suffix", "anything").build()), hasSize(1));
    // breaks, has size 0
    assertThat(affixSetting.getNamespaces(Settings.builder().put("prefix.infix.suffix.anything", "anything").build()), hasSize(1));
}

[spinscale]

Side note: I think the best workaround here would be to get rid of group settings all together. They just add leniency.

[PnPie]

Hello,
It seems that AffixSetting accept only list settings (among settings who has a complex pattern), so I modified the regex pattern to make it also support group settings.

[jasontedor]

@PnPie Thanks for the interest @PnPie but please note that this issue does not have the adoptme label; there is work on this issue in-flight already.

[PnPie]

Okay, I just see that it's not assigned, there is no problem :)