Remove geohash_cell and geo_distance_range queries

[dadoonet]

Related to #21670

We are still documenting geo_distance_range in our docs:

• Ref Guide
• Java Guide

And also Java Client users can still see the related builders without any deprecation notice:

• geohash_cell
• geo_distance_range

In 5.0, 5.1 and 5.x branches we should mark related methods and classes as deprecated, same for our documentation (ref guide and java guide)
In 6.0 we should remove those methods.

In 5.0 series, we should use the deprecation logger in case anyone is using that on 2.x indices.
For 5.x indices, it fails nicely with messages like:

• [failed to parse [geohash_cell] query. geo_point field no longer supports geohash_cell queries]
• [geo_distance_range] queries are no longer supported for geo_point field types. Use geo_distance sort or aggregations

[clintongormley]

@nknize i thought that the geo_distance_range query was coming back?

[jpountz]

From a recent conversation with @nknize, it will not come back.

[javanna]

I was looking into adding deprecation warnings for geo_distance_range and geohash_cell queries in 5.x, but I got confused. Did I get it right that those queries can't be used already against 5.x indices as they throw error? But it seems like they were never deprecated and we kinda removed the support for them already in 5.0 (unless they are executed against 2.x indices, in which case they work)? Not sure what the best way to document this is.

[jpountz]

I agree we should have made the transition more smooth. Your understanding that they work on 2.x indices and fail on 5.x indices sounds correct to me. Geo-hash cell feels very esoteric to me so I am not too concerned, but for geo_distance_range, maybe we should try to bring it back on the 5.x series, even if that means having limitations such as only working on single-valued fields? We should also mark both queries as deprecated in the docs and Java APIs.

[javanna]

We should also mark both queries as deprecated in the docs and Java APIs.

and print out deprecation warnings when they are used ;)