Skip to content

Commit fc35d51

Browse files
committed
[TEST] Fix FieldSortIT failures
1 parent eea010b commit fc35d51

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

core/src/test/java/org/elasticsearch/search/sort/FieldSortIT.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1526,14 +1526,18 @@ public void testCustomFormat() throws Exception {
15261526
}
15271527

15281528
public void testScriptFieldSort() throws Exception {
1529-
createIndex("test");
1529+
assertAcked(prepareCreate("test")
1530+
.addMapping("t", "keyword", "type=keyword", "number", "type=integer"));
15301531
ensureGreen();
15311532
final int numDocs = randomIntBetween(10, 20);
15321533
IndexRequestBuilder[] indexReqs = new IndexRequestBuilder[numDocs];
1534+
List<String> keywords = new ArrayList<>();
15331535
for (int i = 0; i < numDocs; ++i) {
15341536
indexReqs[i] = client().prepareIndex("test", "t")
1535-
.setSource("number", Integer.toString(i));
1537+
.setSource("number", i, "keyword", Integer.toString(i));
1538+
keywords.add(Integer.toString(i));
15361539
}
1540+
Collections.sort(keywords);
15371541
indexRandom(true, indexReqs);
15381542

15391543
{
@@ -1545,7 +1549,7 @@ public void testScriptFieldSort() throws Exception {
15451549
.addSort(SortBuilders.scoreSort())
15461550
.execute().actionGet();
15471551

1548-
int expectedValue = 0;
1552+
double expectedValue = 0;
15491553
for (SearchHit hit : searchResponse.getHits()) {
15501554
assertThat(hit.getSortValues().length, equalTo(2));
15511555
assertThat(hit.getSortValues()[0], equalTo(expectedValue++));
@@ -1565,7 +1569,7 @@ public void testScriptFieldSort() throws Exception {
15651569
int expectedValue = 0;
15661570
for (SearchHit hit : searchResponse.getHits()) {
15671571
assertThat(hit.getSortValues().length, equalTo(2));
1568-
assertThat(hit.getSortValues()[0], equalTo(Integer.toString(expectedValue++)));
1572+
assertThat(hit.getSortValues()[0], equalTo(keywords.get(expectedValue++)));
15691573
assertThat(hit.getSortValues()[1], equalTo(1f));
15701574
}
15711575
}

0 commit comments

Comments
 (0)