Skip to content

Commit f6eefd4

Browse files
committed
Increase suite timeout to 30 minutes for docs tests (#40521)
I have been hitting the suite timeout on `DocsClientYamlTestSuiteIT` As far as I can see, the docs tests are taking quite a while, I assume it's because more and more docs snippets get added over time, which means more tests. The current suite timeout is the default 20 minutes. It takes me just a little less than 20 minutes to run these on my laptop. On my CI, I end up hitting the suite timeout. Hereby I propose that we increase the suite timeout to 30 minutes.
1 parent 444b4c4 commit f6eefd4

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

docs/src/test/java/org/elasticsearch/smoketest/DocsClientYamlTestSuiteIT.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,12 @@
1919

2020
package org.elasticsearch.smoketest;
2121

22-
import org.apache.http.HttpHost;
23-
import org.apache.lucene.util.BytesRef;
24-
2522
import com.carrotsearch.randomizedtesting.annotations.Name;
2623
import com.carrotsearch.randomizedtesting.annotations.ParametersFactory;
24+
import com.carrotsearch.randomizedtesting.annotations.TimeoutSuite;
25+
import org.apache.http.HttpHost;
26+
import org.apache.lucene.util.BytesRef;
27+
import org.apache.lucene.util.TimeUnits;
2728
import org.elasticsearch.Version;
2829
import org.elasticsearch.client.RestClient;
2930
import org.elasticsearch.common.ParseField;
@@ -48,12 +49,13 @@
4849
import java.util.List;
4950
import java.util.Map;
5051

51-
import static org.elasticsearch.common.xcontent.ConstructingObjectParser.constructorArg;
52-
5352
import static java.util.Collections.emptyMap;
5453
import static java.util.Collections.singletonList;
5554
import static java.util.Collections.singletonMap;
55+
import static org.elasticsearch.common.xcontent.ConstructingObjectParser.constructorArg;
5656

57+
//The default 20 minutes timeout isn't always enough, please do not increase further than 30 before analyzing what makes this suite so slow
58+
@TimeoutSuite(millis = 30 * TimeUnits.MINUTE)
5759
public class DocsClientYamlTestSuiteIT extends ESClientYamlSuiteTestCase {
5860

5961
public DocsClientYamlTestSuiteIT(@Name("yaml") ClientYamlTestCandidate testCandidate) {

0 commit comments

Comments
 (0)